fra589 / grbl-Mega-5X

5/6 Axis version of Grbl, the open source, embedded, high performance g-code-parser and CNC milling controller written in optimized C that will run on an Arduino Mega2560
https://github.com/fra589/grbl-Mega-5X/wiki
Other
344 stars 161 forks source link

Additional files to allow compiling within VisualCode via PlatformIO #212

Closed HattonLe closed 3 years ago

HattonLe commented 3 years ago

Added platformio.ini and .vscode folder to allow building of codebase via PlatformIO.

fra589 commented 3 years ago

Hi @casiobearing,

Thanks for your grbl-Mega-5X's interest, I always appreciate people who want to contribute.

Unfortunately, I can't add those files to the standard distribution of grbl-Mega-5X because those files are specific to the operating system and specific to the location of files on the system. They must be specifically configured for the specific machine where there are located.
For example, in the files you propose to add, there are absolutes paths to your specific Windows installation.

grbl-Mega-5X main repository is developed under Debian Linux with a simple editor (Geany) and can be simply build with the avr-gcc C compiler after editing the Makefile for specific adaptations (location of device for example).

So, I added those VisualCode files (.vscode folder and platformio.ini) unnecessary for other people than you, to the .gitignore file.

@++;
Gauthier.

HattonLe commented 3 years ago

Hi,

I think you will find that those absolute paths are automatically rebuilt by VisualCode as soon as you browse to the project folder to originally open it.

Regards Ian

-- Sent with Tutanota, the secure & ad-free mailbox.

19 Sept 2021, 16:31 by @.***:

Hi > @casiobearing https://github.com/casiobearing> ,

Thanks for your grbl-Mega-5X's interest, I always appreciate people who want to contribute.

Unfortunately, I can't add those files to the standard distribution of grbl-Mega-5X because those files are specific to the operating system and specific to the location of files on the system. They must be specifically configured for the specific machine where there are located. For example, in the files you propose to add, there are absolutes paths to your specific Windows installation.

grbl-Mega-5X main repository is developed under Debian Linux with a simple editor (Geany) and can be simply build with the avr-gcc C compiler after editing the Makefile for specific adaptations (location of device for example).

So, I added those VisualCode files (.vscode folder and platformio.ini) unnecessary for other people than you, to the .gitignore file.

@++; Gauthier.

— You are receiving this because you were mentioned. Reply to this email directly, > view it on GitHub https://github.com/fra589/grbl-Mega-5X/pull/212#issuecomment-922492281> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/AEF5O3DK5X6QNLJWVKHH7XTUCX633ANCNFSM5EJKJQSQ> . Triage notifications on the go with GitHub Mobile for > iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or > Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub> .

fra589 commented 3 years ago

Hi,