frace / git-passport

A Git command and hook written in Python to manage multiple Git accounts / user identities.
https://github.com/frace/git-passport
Other
109 stars 25 forks source link

Python3: dict.items() vs. dict.iteritems() #11

Closed frace closed 9 years ago

frace commented 9 years ago

For performance, you can always use iteritems on dictionaries if you don't need the intermediate list.

Reference: http://codereview.stackexchange.com/a/77176

@Ferada As far as I know iteritems() is gone in Python3 instead items() returns an iterator now. See:

Ferada commented 9 years ago

Ah, my bad.

frace commented 9 years ago

Btw. I already fixed some issues you mentioned. I marked and will mark all of those as code review and reference your original review. So if you want to you are able to follow the process and are able to comment if you feel like. :)

Ferada commented 9 years ago

Yeah, yeah I saw them :+1:. I'll try out the program and see if I can contribute later.

frace commented 9 years ago

Nice!