search

fract4d / gnofract4d

A fractal generation program for linux
Other
116 stars 27 forks source link

Combine smaller GUI files #228

Closed cjmayo closed 3 years ago

cjmayo commented 3 years ago

The recent tidying up left some files containing a single class of 30 lines or so. Here are suggested ways to reduce the number of files:

DlgAdvOpt.py and director_prefs.py -> director_dialogs.py (test_director_dialogs.py renamed from test_director_prefs.py)

toolbar.py merged into application_widgets.py

dialog.py merged into utils.py

saves 30 lines as well.

codecov[bot] commented 3 years ago

Codecov Report

Merging #228 (c661a60) into master (544bfd5) will decrease coverage by 0.00%. The diff coverage is 90.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   85.97%   85.97%   -0.01%     
==========================================
  Files          57       54       -3     
  Lines       10411    10407       -4     
==========================================
- Hits         8951     8947       -4     
  Misses       1460     1460
Impacted Files Coverage Δ
fract4dgui/director.py 61.51% <60.00%> (ø)
fract4dgui/utils.py 79.74% <66.66%> (-3.07%) :arrow_down:
fract4dgui/application_widgets.py 91.66% <100.00%> (+1.34%) :arrow_up:
fract4dgui/application_window.py 89.69% <100.00%> (ø)
fract4dgui/autozoom.py 80.35% <100.00%> (ø)
fract4dgui/browser.py 81.04% <100.00%> (ø)
fract4dgui/director_dialogs.py 67.01% <100.00%> (ø)
fract4dgui/painter.py 91.30% <100.00%> (ø)
fract4dgui/preferences.py 76.61% <100.00%> (ø)
fract4dgui/renderqueue.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 544bfd5...0b6aeef. Read the comment docs.