fract4d / gnofract4d

A fractal generation program for linux
Other
116 stars 27 forks source link

Create FractalSettingsTable #231

Closed cjmayo closed 3 years ago

cjmayo commented 3 years ago

First some more tidying of gtkfractal.py, then split out a new class FractalSettingsTable from gtkfractal.T into a new file settings_widgets.py (creating test_settings_widgets.py).

The code moved creates widgets for the Fractal Settings pane, and isn't used by the Preview or SubFract fractals. Moving it makes gtkfractal.T clearer and reduces gtkfractal.py by about a third.

codecov[bot] commented 3 years ago

Codecov Report

Merging #231 (4b8a6cc) into master (544bfd5) will decrease coverage by 0.01%. The diff coverage is 78.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   85.97%   85.95%   -0.02%     
==========================================
  Files          57       58       +1     
  Lines       10411    10391      -20     
==========================================
- Hits         8951     8932      -19     
+ Misses       1460     1459       -1     
Impacted Files Coverage Δ
fract4dgui/settings.py 80.39% <66.66%> (+0.13%) :arrow_up:
fract4dgui/settings_widgets.py 78.50% <78.50%> (ø)
fract4dgui/gtkfractal.py 83.19% <100.00%> (+0.99%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 544bfd5...a3964d7. Read the comment docs.