search

fract4d / gnofract4d

A fractal generation program for linux
Other
115 stars 29 forks source link

Allow "Save changes" dialog to be closed by Escape #234

Closed cjmayo closed 3 years ago

cjmayo commented 3 years ago

One fix for pressing Escape causes the "Save changes" exit dialog to be reshown.

Plus some final tidying up that is the end of this sequence of changes from me.

codecov[bot] commented 3 years ago

Codecov Report

Merging #234 (2bbc2b6) into master (8e103be) will decrease coverage by 0.00%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   85.94%   85.94%   -0.01%     
==========================================
  Files          55       55              
  Lines       10388    10387       -1     
==========================================
- Hits         8928     8927       -1     
  Misses       1460     1460
Impacted Files Coverage Δ
fract4dgui/main_window.py 63.88% <0.00%> (ø)
fract4dgui/application_window.py 89.14% <100.00%> (-0.05%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e103be...2bbc2b6. Read the comment docs.

edyoung commented 3 years ago

Chris, I am way behind on reviewing your series of changes. Thanks so much for making them and sorry for the hold up. Please feel free to merge them when you think they are ready, without waiting for sign off. these all sounds like worthy updates. Thanks again!

cjmayo commented 3 years ago

Thanks @edyoung, good to know you are happy with the changes and thanks to @DX-MON for the reviews. Definitely preferable to have the reviews but got to be realistic.