codecov[bot]
commented
1 year ago Codecov Report
Merging #253 (061a816) into master (c33274f) will decrease coverage by
0.13%. The diff coverage is68.13%.
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
- Coverage 85.86% 85.74% -0.13%
==========================================
Files 55 55
Lines 10375 10418 +43
==========================================
+ Hits 8909 8933 +24
- Misses 1466 1485 +19 | Impacted Files | Coverage Δ | |
|---|---|---|
| fract4dgui/AVIGen.py | 10.00% <5.00%> (-0.59%) |
:arrow_down: |
| fract4dgui/main_window.py | 64.81% <31.73%> (+0.93%) |
:arrow_up: |
| fract4dgui/angle.py | 59.52% <34.28%> (-24.20%) |
:arrow_down: |
| fract4dgui/director_dialogs.py | 66.66% <48.48%> (ø) |
|
| fract4dgui/preferences.py | 76.13% <51.35%> (-0.48%) |
:arrow_down: |
| fract4dgui/utils.py | 82.22% <65.21%> (+2.47%) |
:arrow_up: |
| fract4dgui/PNGGen.py | 83.57% <72.72%> (-0.46%) |
:arrow_down: |
| fract4dgui/application_window.py | 87.50% <73.21%> (-1.18%) |
:arrow_down: |
| fract4dgui/director.py | 60.00% <74.00%> (-0.73%) |
:arrow_down: |
| fract4dgui/settings_widgets.py | 77.83% <77.54%> (-0.67%) |
:arrow_down: |
| ... and 10 more |
... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
edyoung
cjmayo
dragonmux
One clear advantage of GTK 4 for Gnofract 4D is that it makes it easy to fix the high CPU usage while dragging the selection rectangle #14. With the new scene graph a widget's render node is cached. We can split the selection and fractal into separate widgets and only update the fractal widget when there are actual changes. This can be done without cairo, removing the need for it as an external dependency. (Angles and Fourways are still drawn with cairo, but Gtk.Snapshot provides the context).
If there is more than one keyboard device connected that might cause a problem for the code in this PR to detect ctrl/shift pressed with the mouse button on the fractal. PyGObject can't handle Gdk.Event types, which is needed to get the modifier from the drag gesture. Therefore, a workaround is used to get the modifier directly from the keyboard. Possibly it could be extended to cover the multi-keyboard situation.When? GTK 4 is available in Ubuntu 22.04, a few months to go before a new release of Debian stable with it.