Settings validation and cascade deletion

fractal-analytics-platform / fractal-server

Fractal backend

BSD 3-Clause "New" or "Revised" License

10 stars 3 forks source link

DB

[x] Setup cascade delete: deleting a user also deletes their settings (note: this action is not exposed in the API)

API

[x] It seems that the /auth/users/{user_id}/settings endpoint accepts empty strings in the SLURM accounts array: slurm_accounts: [""]

Task-collection and job-execution API

[x] Let's add slurm_accounts: list[str] to the required and validated settings, both for sudo and ssh slurm backends

Checklist before merging

[ ] I added an appropriate entry to CHANGELOG.md
[ ] I added logging to new code - if appropriate.
[ ] I merged main into the current branch.

Coverage report

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
fractal_server/app
user_settings.py	$This PR adds 12 statements to fractal_server/app/user_settings.py. The file did not seem to exist on the base branch.$	$This PR adds 0 statements missing coverage to fractal_server/app/user_settings.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/user_settings.py is 100% (12/12). The file did not seem to exist on the base branch.$	$In this PR, 1 new statements are added to fractal_server/app/user_settings.py, 1 of which are covered (100%).$
fractal_server/app/routes/aux
validate_user_settings.py	$This PR adds 27 statements to fractal_server/app/routes/aux/validate_user_settings.py. The file did not seem to exist on the base branch.$	$This PR adds 0 statements missing coverage to fractal_server/app/routes/aux/validate_user_settings.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/routes/aux/validate_user_settings.py is 100% (27/27). The file did not seem to exist on the base branch.$	$In this PR, 2 new statements are added to fractal_server/app/routes/aux/validate_user_settings.py, 2 of which are covered (100%).$
fractal_server/app/schemas
user_settings.py	$This PR adds 57 statements to fractal_server/app/schemas/user_settings.py. The file did not seem to exist on the base branch.$	$This PR adds 1 statements missing coverage to fractal_server/app/schemas/user_settings.py. The file did not seem to exist on the base branch.$	$The coverage rate of fractal_server/app/schemas/user_settings.py is 98.24% (56/57). The file did not seem to exist on the base branch.$	$In this PR, 7 new statements are added to fractal_server/app/schemas/user_settings.py, 6 of which are covered (85.71%).$	70
Project Total

File

Statements

Missing

Coverage

Coverage
(new stmts)

Lines missing

fractal_server/app

user_settings.py

$This PR adds 12 statements to fractal_server/app/user_settings.py. The file did not seem to exist on the base branch.$

$This PR adds 0 statements missing coverage to fractal_server/app/user_settings.py. The file did not seem to exist on the base branch.$

$The coverage rate of fractal_server/app/user_settings.py is 100% (12/12). The file did not seem to exist on the base branch.$

$In this PR, 1 new statements are added to fractal_server/app/user_settings.py, 1 of which are covered (100%).$

fractal_server/app/routes/aux

validate_user_settings.py

$This PR adds 27 statements to fractal_server/app/routes/aux/validate_user_settings.py. The file did not seem to exist on the base branch.$

$This PR adds 0 statements missing coverage to fractal_server/app/routes/aux/validate_user_settings.py. The file did not seem to exist on the base branch.$

$The coverage rate of fractal_server/app/routes/aux/validate_user_settings.py is 100% (27/27). The file did not seem to exist on the base branch.$

$In this PR, 2 new statements are added to fractal_server/app/routes/aux/validate_user_settings.py, 2 of which are covered (100%).$

fractal_server/app/schemas

user_settings.py

$This PR adds 57 statements to fractal_server/app/schemas/user_settings.py. The file did not seem to exist on the base branch.$

$This PR adds 1 statements missing coverage to fractal_server/app/schemas/user_settings.py. The file did not seem to exist on the base branch.$

$The coverage rate of fractal_server/app/schemas/user_settings.py is 98.24% (56/57). The file did not seem to exist on the base branch.$

$In this PR, 7 new statements are added to fractal_server/app/schemas/user_settings.py, 6 of which are covered (85.71%).$

Project Total

fractal-analytics-platform / fractal-server