fractal-analytics-platform / fractal-server

Fractal backend
https://fractal-analytics-platform.github.io/fractal-server/
BSD 3-Clause "New" or "Revised" License
11 stars 3 forks source link

Fix github CI #479

Closed tcompa closed 1 year ago

tcompa commented 1 year ago

Something is wrong with the github CI. It currently fails in main/py3.8, although the same run did succeed previously:

Success: https://pipelines.actions.githubusercontent.com/serviceHosts/0a5165d8-4fe3-4e35-ac8e-5e3bf98b1842/_apis/pipelines/1/runs/1516/signedlogcontent/2?urlExpires=2023-01-27T10%3A53%3A51.7033985Z&urlSigningMethod=HMACV1&urlSignature=t0y7Bkv26WGi2TAFf7873Om8DezMd3obV44gaVnHR4Y%3D

Failure: https://pipelines.actions.githubusercontent.com/serviceHosts/0a5165d8-4fe3-4e35-ac8e-5e3bf98b1842/_apis/pipelines/1/runs/1536/signedlogcontent/2?urlExpires=2023-01-27T10%3A54%3A00.3499637Z&urlSigningMethod=HMACV1&urlSignature=AGiq7KJLQvYYlHfXrsrKwHdB4o3%2FdwV8WDwcOdrAxeA%3D

The error has to do with test_backend_slurm, and for this reason testing on github for open PRs #475 and #478 is less reliable.

tcompa commented 1 year ago

Quoting from #480:

We found a major issue in the CI (thanks @ychiucco!), i.e. fractal-server install in docker container was pulling the fresh sqlalchemy 2.0 version (released yesterday), which introduces major changes and is not (yet) supported by our dependencies.

This is currently addressed by pinning to >=1.4,<2, and we should also come back to this later if a PR like https://github.com/fastapi-users/fastapi-users-db-sqlmodel/pull/13 is merged (I think this is the dependency which is currently holding us back at 1.4.35), to make sure that we would fetch more recent 1.4 versions if possible.

Meanwhile, another small issue (cfut_finished_jobs fixture missing in some tests, and its actual code being slightly different from the cfut=0.5 final version) surfaced, and is fixed here.

Closing this issue, let's open more specific ones if needed.