fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
14 stars 6 forks source link

Switch docstring style to Google style? #397

Closed jluethi closed 1 year ago

jluethi commented 1 year ago

As discussed at today's call, we should consider (e.g. for the next maintenance week) whether we should switch the docstring style in fractal-tasks-core to the google style (see here)

Benefits: More in line with other Fractal packages like fractal-server

Things that would need to be done: Update all docstrings Update documentation building

tcompa commented 1 year ago

For the record, we found (with @ychiucco) that https://rr-.github.io/docstring_parser/#compose does a reasonable job in automatically converting a docstring to a different style.

tcompa commented 1 year ago

A first version of this PR is in now in-place, see #473. For the moment:

To review:

What we achieve / where could we go:

(*) Note: the CLI client docs currently rely on https://sphinx-argparse.readthedocs.io, and then we would need to find an alternative in order to move all repositories to mkdocs. Maybe https://github.com/chriskiehl/ArgDoc? TBD.


Given the current situation, I wouldn't push for mkdocs as a priority. When/if we realize that this would be helpful for using markdown, we can reconsider.

tcompa commented 1 year ago
  • Check that documentation is fully equivalent to the previous one. This is in progress. The two versions look fairly similar, but I need to review them more carefully.

I went through all modules and visually compared the old/new docs, and they are identical (apart from minor fixes that were introduced on purpose).