search

fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
14 stars 6 forks source link

Review 2D & 3D image handling in napari workflows #411

Open jluethi opened 1 year ago

jluethi commented 1 year ago

See https://github.com/fractal-analytics-platform/fractal-tasks-core/pull/403 and https://github.com/fractal-analytics-platform/fractal-tasks-core/issues/398

I covered some scenarios, but I'm not sure whether the "calculate a label image in napari workflows based on an actual 2D image OME-Zarr intensity image" would work as expected. I think it should (and should just be saved as an actual 2D image), but to be tested a bit further. Plus test the different interactions with expected_dimensions and if there are weird edge cases there

I should review this and check whether the napari workflows flow can be simplified.

jluethi commented 1 year ago

Also review the napari workflow tests and see if we can increase coverage for the different 2D vs 3D scenarios