fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
14 stars 6 forks source link

Update anndata (version and import source of `write_elem`) #427

Closed tcompa closed 1 year ago

tcompa commented 1 year ago

See https://anndata.readthedocs.io/en/stable/release-notes/index.html

jluethi commented 1 year ago

Would be great to evaluate this. I think the write_elem has now also moved out of the experimental part, thus maybe we can ignore anndata's torch interactions with that. I'll test this briefly for the md converter, where write_elem in experimental has been making some issues.

jluethi commented 1 year ago

Actually, the more important part will be this: Let's switch to using the write_elem function as ad._io.specs.write_elem, instead of importing it from experimental. It has worked in my tests for the MD, let's try also on the Fractal side.

The big benefit: ad._io.specs does not import torch => no more anndata worries about torch.

See: https://github.com/jluethi/fractal-faim-hcs/issues/1

tcompa commented 1 year ago

Let's switch to using the write_elem function as ad._io.specs.write_elem, instead of importing it from experimental. It has worked in my tests for the MD, let's try also on the Fractal side.

The big benefit: ad._io.specs does not import torch => no more anndata worries about torch.

Fully agreed.

For the record: