search

fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
14 stars 6 forks source link

Fix plate selection in copy_ome_zarr task #513

Closed tcompa closed 1 year ago

tcompa commented 1 year ago

Close #514 Close #510

Checklist before merging

tcompa commented 1 year ago

Current changes break the copy-ome-zarr task for a multiplexing dataset, I'll check it out.

tcompa commented 1 year ago

Current changes break the copy-ome-zarr task for a multiplexing dataset, I'll check it out.

The reason seems to be that metadata['plate'] is filled differently by the create-ome-zarr and create-ome-zarr-multiplexing tasks: the non-multiplexing task includes a list like ["plate.zarr"], while the multiplexing one includes a list like ["plate"].

tcompa commented 1 year ago

@jluethi I fixed #510 and #514. The new test test_copy_ome_zarr_twice correctly reproduces the wrong behavior you identified in #510, and it is then fixed with https://github.com/fractal-analytics-platform/fractal-tasks-core/pull/513/commits/1482fbd85355fa61b343774e36405a0f1fcaf323.

The changes are very limited, but let me know if they makes sense for you.

github-actions[bot] commented 1 year ago

Coverage report

The coverage rate went from 89.91% to 89.91% :arrow_up: The branch rate is 83%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.