fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
14 stars 6 forks source link

`reset_origin` should not modify its input #525

Closed tcompa closed 11 months ago

tcompa commented 11 months ago

The current version of reset_origin (in lib_regions_of_interest.py) modifies the its ROI-table input and returns it. If it's meant to be an in-place modification, then it should not return. I think the most transparent option is to make a fresh copy and return the updated table.

Refs: