It checks that there is a given ROI with 0, 0, 0 origin. But in some search-first scenario, there are not FOVs at the top left. There is one FOV with y value 0 and one FOV with x value 0, but they do not need to be the same ROI. That would be sufficient and should be a supported use case.
Here is a valid ROI table that now fails, but that worked before (I already did the shifts so everything starts at 0). This ROI table should pass the check, but the current way of checking does not pass.
The
check_valid_ROI_indicesfunction is too strict at the moment, see https://github.com/fractal-analytics-platform/fractal-tasks-core/blob/0ae4590980230734c6b017af2aea7253cdd30926/fractal_tasks_core/lib_regions_of_interest.py#L303C14-L303C14It checks that there is a given ROI with 0, 0, 0 origin. But in some search-first scenario, there are not FOVs at the top left. There is one FOV with y value 0 and one FOV with x value 0, but they do not need to be the same ROI. That would be sufficient and should be a supported use case.
Here is a valid ROI table that now fails, but that worked before (I already did the shifts so everything starts at 0). This ROI table should pass the check, but the current way of checking does not pass.
site_metadata_ZebrafishMultiplexing_cycle0_new_rois.csv