At the moment, our Calculate registration (image-based) task assumes all ROI tables contain the colums "x_micrometer_original" and "y_micrometer_original". That's not always the case and not enforced by our ROI table specification => make this more general.
Easiest way to trigger it: Run it on the well_ROI_table
Get the following error:
2023-10-25 12:46:11,922; INFO; Updating the roi_table='well_ROI_table' with translation columns
Traceback (most recent call last):
File "/net/nfs4/pelkmanslab-fileserver-fractal/data/homes/fractal/20230627_joel_fractal/fractal-demos/examples/server/FRACTAL_TASKS_DIR/.fractal/fractal-tasks-core0.13.0/venv/lib/python3.10/site-packages/fractal_tasks_core/tasks/calculate_registration_image_based.py", line 349, in <module>
run_fractal_task(
File "/data/homes/fractal/20230627_joel_fractal/fractal-demos/examples/server/FRACTAL_TASKS_DIR/.fractal/fractal-tasks-core0.13.0/venv/lib/python3.10/site-packages/fractal_tasks_core/tasks/_utils.py", line 79, in run_fractal_task
metadata_update = task_function(**pars)
File "pydantic/decorator.py", line 40, in pydantic.decorator.validate_arguments.validate.wrapper_function
File "pydantic/decorator.py", line 134, in pydantic.decorator.ValidatedFunction.call
File "pydantic/decorator.py", line 206, in pydantic.decorator.ValidatedFunction.execute
File "/net/nfs4/pelkmanslab-fileserver-fractal/data/homes/fractal/20230627_joel_fractal/fractal-demos/examples/server/FRACTAL_TASKS_DIR/.fractal/fractal-tasks-core0.13.0/venv/lib/python3.10/site-packages/fractal_tasks_core/tasks/calculate_registration_image_based.py", line 255, in calculate_registration_image_based
new_ROI_table = get_ROI_table_with_translation(ROI_table_x, new_shifts)
File "/net/nfs4/pelkmanslab-fileserver-fractal/data/homes/fractal/20230627_joel_fractal/fractal-demos/examples/server/FRACTAL_TASKS_DIR/.fractal/fractal-tasks-core0.13.0/venv/lib/python3.10/site-packages/fractal_tasks_core/tasks/calculate_registration_image_based.py", line 339, in get_ROI_table_with_translation
X=new_roi_table.loc[:, positional_columns].astype(np.float32)
File "/data/homes/fractal/20230627_joel_fractal/fractal-demos/examples/server/FRACTAL_TASKS_DIR/.fractal/fractal-tasks-core0.13.0/venv/lib/python3.10/site-packages/pandas/core/indexing.py", line 1067, in __getitem__
return self._getitem_tuple(key)
File "/data/homes/fractal/20230627_joel_fractal/fractal-demos/examples/server/FRACTAL_TASKS_DIR/.fractal/fractal-tasks-core0.13.0/venv/lib/python3.10/site-packages/pandas/core/indexing.py", line 1256, in _getitem_tuple
return self._getitem_tuple_same_dim(tup)
File "/data/homes/fractal/20230627_joel_fractal/fractal-demos/examples/server/FRACTAL_TASKS_DIR/.fractal/fractal-tasks-core0.13.0/venv/lib/python3.10/site-packages/pandas/core/indexing.py", line 924, in _getitem_tuple_same_dim
retval = getattr(retval, self.name)._getitem_axis(key, axis=i)
File "/data/homes/fractal/20230627_joel_fractal/fractal-demos/examples/server/FRACTAL_TASKS_DIR/.fractal/fractal-tasks-core0.13.0/venv/lib/python3.10/site-packages/pandas/core/indexing.py", line 1301, in _getitem_axis
return self._getitem_iterable(key, axis=axis)
File "/data/homes/fractal/20230627_joel_fractal/fractal-demos/examples/server/FRACTAL_TASKS_DIR/.fractal/fractal-tasks-core0.13.0/venv/lib/python3.10/site-packages/pandas/core/indexing.py", line 1239, in _getitem_iterable
keyarr, indexer = self._get_listlike_indexer(key, axis)
File "/data/homes/fractal/20230627_joel_fractal/fractal-demos/examples/server/FRACTAL_TASKS_DIR/.fractal/fractal-tasks-core0.13.0/venv/lib/python3.10/site-packages/pandas/core/indexing.py", line 1432, in _get_listlike_indexer
keyarr, indexer = ax._get_indexer_strict(key, axis_name)
File "/data/homes/fractal/20230627_joel_fractal/fractal-demos/examples/server/FRACTAL_TASKS_DIR/.fractal/fractal-tasks-core0.13.0/venv/lib/python3.10/site-packages/pandas/core/indexes/base.py", line 6070, in _get_indexer_strict
self._raise_if_missing(keyarr, indexer, axis_name)
File "/data/homes/fractal/20230627_joel_fractal/fractal-demos/examples/server/FRACTAL_TASKS_DIR/.fractal/fractal-tasks-core0.13.0/venv/lib/python3.10/site-packages/pandas/core/indexes/base.py", line 6133, in _raise_if_missing
raise KeyError(f"{not_found} not in index")
KeyError: "['x_micrometer_original', 'y_micrometer_original'] not in index"
At the moment, our
Calculate registration (image-based)task assumes all ROI tables contain the colums "x_micrometer_original" and "y_micrometer_original". That's not always the case and not enforced by our ROI table specification => make this more general.Easiest way to trigger it: Run it on the well_ROI_table
Get the following error:
I will create a fix.