search

fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
12 stars 5 forks source link

590 generalize calculate registration roi table handling #591

Closed jluethi closed 8 months ago

jluethi commented 8 months ago

Closes #590

The assumptions on which (additional) columns are in a ROI table are not necessary. Now, the helper function just adds the columns "translation_z", "translation_y", "translation_x" and keeps all existing columns. The behavior is not changing for the FOV_ROI_tables, but now well_ROI_tables should also be supported.

I added a test case for the function itself. It's tricky to build a whole test case around the well_ROI_table that will work reliably (given the way we currently create test data by modifying the original FOV images, a well-based registration isn't expected to work reliably) and x_micrometer_original isn't used anywhere else in the task.

Checklist before merging

@tcompa Can you have a look and once this is merged, release a 0.13.1 with it?

github-actions[bot] commented 8 months ago

Coverage report

The coverage rate went from 90.48% to 90.47% :arrow_down: The branch rate is 84%.

100% of new lines are covered.

Diff Coverage details (click to unfold) ### fractal_tasks_core/tasks/calculate_registration_image_based.py `100%` of new lines are covered (`91.07%` of the complete file).