search

fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
14 stars 6 forks source link

Fix ROI table usage in calculate registration task: use table of correct component #614

Closed jluethi closed 10 months ago

jluethi commented 10 months ago

At the moment, we load the ROI tables of the reference cycle for both the reference cycle and the to-be-aligned cycle:

https://github.com/fractal-analytics-platform/fractal-tasks-core/blob/f3326c415587d8fc1ae3fd05d608c20ea54e9a4a/fractal_tasks_core/tasks/calculate_registration_image_based.py#L149-L150

This didn't raise issues so far because in most cases, those tables are actually the same. But it can lead to issues in edge-cases, because that's not a generalizable assumption. Thanks @nrepina for spotting this!