fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Refactor `is_ROI_table_valid` #633

Open tcompa opened 6 months ago

tcompa commented 6 months ago

This came up during #600 and #631 (see https://github.com/fractal-analytics-platform/fractal-tasks-core/issues/600#issuecomment-1851517526), and we are currently postponing it.

fractal_tasks_core.roi.is_ROI_table_valid, where we validate both the ROI contents and the Zarr attributes --> maybe we can refactor this one?

Not necessary for the 0.14.0 release. Who should be checking the attrs in the end? I can see that it would come from a function in fractal_tasks_core.tables to load the attrs, but we also didn't really want to have it there, right?