fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Handle race condition in Apply Registration to image task better #638

Closed jluethi closed 5 months ago

jluethi commented 5 months ago

@adrtsc I'm proposing a fix here for https://github.com/fractal-analytics-platform/fractal-tasks-core/issues/516 that introduces a max_retries parameter. I set it to 20, but we can of course tune that parameter further if needed.

closes #516

Checklist before merging

github-actions[bot] commented 5 months ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_tasks_core/tasks
  apply_registration_to_image.py 221-227
Project Total  

This report was generated by python-coverage-comment-action

jluethi commented 5 months ago

What we are missing in coverage here is reproducing a race time conflict during the tests. Given that it's a workaround, I'm fine with not having this included in our tests.

adrtsc commented 5 months ago

Looks good to me!