Remove unnecessary split of component in well & plate info in cellpose task - Githubissues

fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform

https://fractal-analytics-platform.github.io/fractal-tasks-core/

BSD 3-Clause "New" or "Revised" License

11 stars 5 forks source link

Remove unnecessary split of component in well & plate info in cellpose task #659

Closed jluethi closed 3 months ago

jluethi commented 4 months ago

Checklist before merging

[ ] I added an appropriate entry to CHANGELOG.md

jluethi commented 4 months ago

See discussion here on issues with this split: https://forum.image.sc/t/fractal-framework-zarr-compatibility/92536

Let's wait to see whether other issues arise in this context on e.g. component path assumptions

github-actions[bot] commented 4 months ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
fractal_tasks_core/tasks
cellpose_segmentation.py	$This PR removes 1 from the number of statements in fractal_tasks_core/tasks/cellpose_segmentation.py, taking it from 211 to 210.$	$This PR doesn't change the number of statements missing coverage in fractal_tasks_core/tasks/cellpose_segmentation.py, which is 24.$	$This PR removes 0.05 percentage points from the coverage rate in fractal_tasks_core/tasks/cellpose_segmentation.py, taking it from 88.62% (187/211) to 88.57% (186/210).$	$This PR does not seem to add statements to fractal_tasks_core/tasks/cellpose_segmentation.py.$
Project Total

This report was generated by python-coverage-comment-action