Closed jluethi closed 7 months ago
Click to see where and how coverage changed
File Statements Missing Coverage Coverage
(new stmts)Lines missing
fractal_tasks_core/tasks
apply_registration_to_image.py
99
Project Total
This report was generated by python-coverage-comment-action
Also doing some minor cleanup in parameter types in apply registration to image and found https://github.com/fractal-analytics-platform/fractal-tasks-core/issues/707 (which is not closed by this PR).
@tcompa This PR is ready for review.
I renamed the napari workflow wrapper task, changed a name of an illumination correction parameter, changed a type in apply_registration_to_image task (& the handling of the registration cycle => how it finds the zarr_url) and reordered some parameters in other tasks.
I also added a consistent comment structure to the Python functions to separate Fractal parameters
, Core parameters
& Advanced parameters
for clarity.
Ah and I removed the old compress_tif "task" that we still had lying around, but never used or tested.
@tcompa This PR is ready for review.
I renamed the napari workflow wrapper task, changed a name of an illumination correction parameter, changed a type in apply_registration_to_image task (& the handling of the registration cycle => how it finds the zarr_url) and reordered some parameters in other tasks. I also added a consistent comment structure to the Python functions to separate
Fractal parameters
,Core parameters
&Advanced parameters
for clarity.
Thanks. I had a look, and I have nothing to add. I'll merge and release 1.0.0a2
Checklist before merging
CHANGELOG.md