fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Make all task names title case & cleanup task parameter naming/ordering #706

Closed jluethi closed 2 months ago

jluethi commented 2 months ago

Checklist before merging

github-actions[bot] commented 2 months ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_tasks_core/tasks
  apply_registration_to_image.py 99
Project Total  

This report was generated by python-coverage-comment-action

jluethi commented 2 months ago

Also doing some minor cleanup in parameter types in apply registration to image and found https://github.com/fractal-analytics-platform/fractal-tasks-core/issues/707 (which is not closed by this PR).

jluethi commented 2 months ago

@tcompa This PR is ready for review.

I renamed the napari workflow wrapper task, changed a name of an illumination correction parameter, changed a type in apply_registration_to_image task (& the handling of the registration cycle => how it finds the zarr_url) and reordered some parameters in other tasks. I also added a consistent comment structure to the Python functions to separate Fractal parameters, Core parameters & Advanced parameters for clarity.

jluethi commented 2 months ago

Ah and I removed the old compress_tif "task" that we still had lying around, but never used or tested.

tcompa commented 2 months ago

@tcompa This PR is ready for review.

I renamed the napari workflow wrapper task, changed a name of an illumination correction parameter, changed a type in apply_registration_to_image task (& the handling of the registration cycle => how it finds the zarr_url) and reordered some parameters in other tasks. I also added a consistent comment structure to the Python functions to separate Fractal parameters, Core parameters & Advanced parameters for clarity.

Thanks. I had a look, and I have nothing to add. I'll merge and release 1.0.0a2