723 Fix illumination correction task not copying tables

fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform

https://fractal-analytics-platform.github.io/fractal-tasks-core/

BSD 3-Clause "New" or "Revised" License

14 stars 6 forks source link

723 Fix illumination correction task not copying tables #724

Closed jluethi closed 7 months ago

jluethi commented 7 months ago

Illumination correction task now correctly copies tables from the original image

github-actions[bot] commented 7 months ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)
fractal_tasks_core/tasks
_zarr_utils.py	$This PR adds 14 to the number of statements in fractal_tasks_core/tasks/_zarr_utils.py, taking it from 55 to 69.$	$This PR doesn't change the number of statements missing coverage in fractal_tasks_core/tasks/_zarr_utils.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_tasks_core/tasks/_zarr_utils.py, which is 100% (69/69).$	$In this PR, 14 new statements are added to fractal_tasks_core/tasks/_zarr_utils.py, 14 of which are covered (100%).$
illumination_correction.py	$This PR adds 2 to the number of statements in fractal_tasks_core/tasks/illumination_correction.py, taking it from 93 to 95.$	$This PR doesn't change the number of statements missing coverage in fractal_tasks_core/tasks/illumination_correction.py, which is 7.$	$This PR adds 0.16 percentage points to the coverage rate in fractal_tasks_core/tasks/illumination_correction.py, taking it from 92.47% (86/93) to 92.63% (88/95).$	$In this PR, 2 new statements are added to fractal_tasks_core/tasks/illumination_correction.py, 2 of which are covered (100%).$
Project Total

This report was generated by python-coverage-comment-action

jluethi commented 7 months ago

I've confirmed that this closes #723, both with tests & with running example 02 while setting overwrite_input to False.

@tcompa I will already merge now so we can proceed with the release & deployment on Monday. The main thing where a review would be great is the new _copy_tables_from_zarr_url function. I already opened an issue here so we can review this further: https://github.com/fractal-analytics-platform/fractal-tasks-core/issues/725