fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Add test for 2D cellvoyager conversion & drop macos tests for Python 3.9 & Python 3.10 #726

Closed jluethi closed 2 months ago

jluethi commented 2 months ago

Closes #684

github-actions[bot] commented 2 months ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_tasks_core/tasks
  cellvoyager_to_ome_zarr_compute.py
Project Total  

This report was generated by python-coverage-comment-action

jluethi commented 2 months ago

It appears that Python 3.9 & macos 14 (which is slowly rolling out on CI) is making issues on Github CI due to issues described here: https://github.com/actions/setup-python/issues/696#issuecomment-1637587760

I will exclude macos Python 3.9 for us, as it's not essential to test all Python versions on all os for our package. Given what appears to be available on those new runners, I'm also dropping macos Python 3.10: https://github.com/actions/runner-images/blob/main/images/macos/macos-13-arm64-Readme.md#cached-tools (otherwise tests will probably fail once we get macos 14 runners for 3.10)

We could manually install Python e.g. via brew on mac runners, but I don't think that's worth the complexity & additional CI time for us. As long as we have 1 macos version being tested.

=> Conclusion is that we'll test broadly on Linux (3.9 - 3.11) & just run 3.11 for macos.

jluethi commented 2 months ago

@tcompa I'm merging this now to get the CI working again. Feel free to open new issues/PRs to improve this later :)