Add breaking test for HCS plate metadata - Githubissues

fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform

https://fractal-analytics-platform.github.io/fractal-tasks-core/

BSD 3-Clause "New" or "Revised" License

14 stars 6 forks source link

Add breaking test for HCS plate metadata #736

Closed jluethi closed 7 months ago

jluethi commented 7 months ago

Closes #735

Checklist before merging

[ ] I added an appropriate entry to CHANGELOG.md

jluethi commented 7 months ago

The bug was in the messy _generate_plate_well_metadata function. Another reason to refactor that function.

For the moment, I just fixed the bug by reverting the switch of rows & columns for plate metadata.

github-actions[bot] commented 7 months ago

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
fractal_tasks_core/tasks
copy_ome_zarr_hcs_plate.py	$This PR doesn't change the number of statements in fractal_tasks_core/tasks/copy_ome_zarr_hcs_plate.py, which is 108.$	$This PR doesn't change the number of statements missing coverage in fractal_tasks_core/tasks/copy_ome_zarr_hcs_plate.py, which is 3.$	$This PR doesn't change the coverage rate in fractal_tasks_core/tasks/copy_ome_zarr_hcs_plate.py, which is 97.22% (105/108).$	$In this PR, 1 new statements are added to fractal_tasks_core/tasks/copy_ome_zarr_hcs_plate.py, 1 of which are covered (100%).$
Project Total

This report was generated by python-coverage-comment-action