search

fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Relax Pydantic V1 constraint from `==1.10.16` to `>=1.10.16` #768

Closed tcompa closed 5 days ago

tcompa commented 1 week ago

cc @lorenzocerrone

lorenzocerrone commented 1 week ago

I will quickly open a pr for this in the afternoon

lorenzocerrone commented 6 days ago

As you mentioned @tcompa during the last pydantic PR review, there is no strong reason to pic pydantic>=2.6.3.

Since I needed to rework the version check anyway, I want to test if the manifest creation is compatible with all pydantic 2* versions. The answer is yes; from version 2.0.0 the manifest building works and has no diffs from the current version in main.

After my tests I don't see any reasons to keep the runtime check. Should I remove it? And just leave the simple version constraint pydantic >=1.10.16?

tcompa commented 6 days ago

After my tests I don't see any reasons to keep the runtime check. Should I remove it? And just leave the simple version constraint pydantic >=1.10.16?

I agree. If we ever hit an issue with some manifest building coming from e.g. pydantic 2.3, we can quickly re-introduce the runtime version constraint. But note that this would only happen if someone is pinning pydantic=2.3 in their own package.