Fix wrong repeated overlap check for bounding-boxes in cellpose task

[tcompa]

Close #764

Checklist before merging

• [x] I added an appropriate entry to CHANGELOG.md

[github-actions[bot]]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
fractal_tasks_core/tasks
cellpose_segmentation.py
Project Total

This report was generated by python-coverage-comment-action

[tcompa]

cc @lorenzocerrone or @jluethi This is ready from my side, and a second look would be welcome. I did not set up a specific benchmark (deferring this to #779), but it's anyway a fix that is needed (even if, by accident, it doesn't fix #764).

[jluethi]

Hmm, looking at this now: This (as well as the original implementation) will only check for potential bounding box overlaps within a given ROI that's being processed, right?

With the new implementation, we'd only check each ROI once, instead of checking all ROIs processed so far in every loop.

A future improvement may be to check for overlaps across ROIs as well, as in theory, they could also overlap. Given that this is just for warnings, not sure how relevant this is though. Our masking should still work for this after all.

---

Besides that: Looks good to me!

[tcompa]

Hmm, looking at this now: This (as well as the original implementation) will only check for potential bounding box overlaps within a given ROI that's being processed, right? With the new implementation, we'd only check each ROI once, instead of checking all ROIs processed so far in every loop.

I confirm. The PR is strictly equivalent to current behavior, but without the redundant calls.

[tcompa]

A future improvement may be to check for overlaps across ROIs as well, as in theory, they could also overlap.

Agreed, but let's do it in a future PR since it requires a bit of care to avoid bad scaling (ref https://github.com/fractal-analytics-platform/fractal-tasks-core/issues/779#issuecomment-2208234941).