fractal-analytics-platform / fractal-tasks-core

Main tasks for the Fractal analytics platform
https://fractal-analytics-platform.github.io/fractal-tasks-core/
BSD 3-Clause "New" or "Revised" License
14 stars 6 forks source link

Update zenodo dataset, setting `channel.active` to True #823

Open tcompa opened 2 months ago

tcompa commented 2 months ago

Ref https://github.com/fractal-analytics-platform/fractal-vizarr-viewer/issues/20.

  1. Review the current situation: how are we setting the active attribute of a channel?
  2. Decide how we should proceed in the converters. Do we always mark all channels as "active"? Do we only do it for at most N channels? ...
tcompa commented 2 months ago

Review the current situation: how are we setting the active attribute of a channel?

How comes we have some zarrs lying around without active=true for channels? For sure the tiny one on zenodo (https://zenodo.org/records/13305156) doesn't have active metadata.

Decide how we should proceed in the converters. Do we always mark all channels as "active"? Do we only do it for at most N channels? ...

I guess that we can continue as we do now. If the user does not specify anything in the converter arguments, all channels are marked as active.

tcompa commented 2 months ago

After re-running examples 01 and 02 from fractal-demos, I confirm that their .zattrs does not include the active field. TBD

jluethi commented 1 month ago

@lorenzocerrone Something to keep in mind in the ngio context. If we can, let's make sure channels have active=True unless there's an active decision against it. That avoids many confusions about channels not being shown e.g. in vizarr ;)