Closed tcompa closed 2 days ago
manifest_version="2"
, has_args_schemas=true
, and args_schema_version="pydantic_v1"
.Screenshot of the new page:
Notice that I added to the repo a copy of the manifest JSON Schema (https://github.com/fractal-analytics-platform/fractal-server/blob/main/fractal_server/json_schemas/manifest_v2.json), since it is not possible to automatically include it in the page from GitHub. Using the <script>
tag it is possible to load JavaScript files as remote resources, but not JSON files. I've tried also with a possible workaround using an <iframe>
, but that is disallowed by a security header added by GitHub server (X-Frame-Options: DENY
), so the only option is to have a local copy of it.
First quick comment (cc @jluethi): should we stick with just supporting V2 manifests, rather than legacy/v2?
That's awesome!
Let's stick with only v2 manifest for sure! We can just show an error if the manifest has an older version than V2 :)
This new manifest version is super powerful during local task development, as the whole manifest gets created by the dev tooling and can then just be uploaded. Can one drag & drop the manifest in there? [if that's tricky to implement, not critical]
I've added a drag and drop area for the manifest file:
That's awesome! Will make for a neat demo! :) 👏🏻
This is a placeholder issue, which will become relevant during/after #512.
Briefly: we could let the user upload a whole manifest (anything upload the file, paste the JSON text, point to an URL), parse it to extract the N tasks and their parallel/non-parallel schemas, and show e.g. a dropdown menu with all tasks. By selecting one, the user would see the corresponding form and values.
High-level: this would be quite useful for a user who built their package and wants to review the whole manifest (are tasks all there? do they look OK in the form? and so on..). The parsing of the manifest is quite simple, and based on this JSON Schema https://github.com/fractal-analytics-platform/fractal-server/blob/main/fractal_server/json_schemas/manifest_v2.json