fractal-code / meteor-azure

Automate Meteor deployments on Azure App Service
MIT License
67 stars 20 forks source link

ROOT_URL in 2 places #37

Closed jycouet closed 7 years ago

jycouet commented 7 years ago

Hi,

Now I have the ROOT_URL 2 times in my setting.json

{
  "meteor-azure": {
    "siteName": "",
    "resourceGroup": "",
    "subscriptionId": "",
    "tenantId": "",
    "deploymentCreds": {
      "username": "",
      "password": ""
    },
    "envVariables": {
      "ROOT_URL": "My Rout URL",
      "MONGO_URL": ""
    }
  },
  "runtime": {
    "meteorEnv": {},
    "DDP_DEFAULT_CONNECTION_URL": "",
    "ROOT_URL": "My Rout URL again :P"
  },
}

Do you have an idea to "merge" these two fields?

Thx

ramijarrar commented 7 years ago

You can use process.env.ROOT_URL to access the value directly, is that what you were after?

jycouet commented 7 years ago

Sorry about the question, actually, the "runtime" section is for https://github.com/Urigo/meteor-client-bundler I wondered how to reuse the same parameter.

I close the question since I did a mistake in meteor-client-bundler config anyway. Yes, meteor-client-bundler is using process.env.ROOT_URL and not runtime.ROOT_URL

Thank you for your support