fractal-code / meteor-azure

Automate Meteor deployments on Azure App Service
MIT License
67 stars 20 forks source link

Meteor 1.6 and bcrypt package #46

Closed conradj closed 7 years ago

conradj commented 7 years ago

This is a modified Todo app, which builds fine on my Mac but I can't deploy to Azure.

Thank you :-)

ramijarrar commented 7 years ago

I suspect this may be package-specific (though we haven't tested with Meteor 1.6 yet) - if this isn't a sensitive codebase, are you comfortable sharing access for reproduction?

conradj commented 7 years ago

Sure, here it is

ramijarrar commented 7 years ago

I was able to reproduce the error on one of our test servers and the issue is isolated to the bcrypt package, which doesn't appear to compile properly for Windows on Meteor 1.6. I'm pretty swamped with work at the moment, so won't get a chance to take a closer look for the next few weeks.

In the meantime though, you should be able to deploy successfully by temporarily removing the bcrypt package (see my fork here) or downgrading back to Meteor 1.5. Let me know if you have any issues with either approach.

conradj commented 7 years ago

Thanks - have removed bcrypt for now and it deployed fine. If I deployed with your modified web.config the app doesn't work - just thought I'd mention it in case it was important!

ramijarrar commented 7 years ago

This has been fixed as of v2.0.8 (along with some other compatibility improvements for Meteor 1.6)

Please let me know if you have any further issues adding bcrypt/other packages and functionality