search

fractal-code / meteor-azure

Automate Meteor deployments on Azure App Service
MIT License
68 stars 20 forks source link

Support ASE deployments #70

Open karthik18k opened 5 years ago

karthik18k commented 5 years ago

I am trying to deploy to app within App Service Environment(ASE) and I get the below error ;

error: : Could not connect to Kudu

I guess the siteName config in the settings.json is used to form azure kudu url like, https://(appname).scm.azurewebsites.net/

This is fine for the default apps. But for the ASE apps the kudu url is - https://(appname).scm.(asename).p.azurewebsites.net/.

Is there an option to configure the kudu endpoint or any other suggestion on this.

ramijarrar commented 5 years ago

For ASE, we need to accept a settings parameter to override the Kudu client base URL here: https://github.com/fractal-code/meteor-azure/blob/ac95deceb57d47fc1332a73a30b65899a80a49b1/source/lib/azure.js#L35-L38

I'm pretty swamped with work this week but would be happy to accept a PR - or could prioritize sooner if you want to post a bounty for this :)

karthik18k commented 5 years ago

Thanks for the quick response.

I have little knowledge on Node. I will update back if I manage to make the changes.