search

fractaledmind / acidic_job

Elegant, resilient, durable workflows for Rails apps
https://fractaledmind.github.io/acidic_job/
MIT License
487 stars 10 forks source link

Remove `to_f` in `set` method to prevent error #98

Open ahacop opened 1 month ago

ahacop commented 1 month ago

This change prevents a NoMethodError when retrying jobs or scheduling jobs with set(wait: ...) for adapters like GoodJob and Solid Queue.

Fixes #92.

I added a test to check that scheduled_at is not cast. I wasn't sure if you thought it was necessary to bring in Solid Queue or Good Job to actually test those adapters. Happy to make changes if you have other suggestions on how to test here.