search

fractaledmind / actionset

Wire-up ActiveSet collections with a Rails controller
MIT License
4 stars 4 forks source link

NULL ordering doesn't work in Oracle #58

Open barendt opened 5 years ago

barendt commented 5 years ago

The current implementation of NULL ordering doesn't work in Oracle. The generated ORDER BY statement causes Oracle to throw OCIError: ORA-00933: SQL command not properly ended.

I believe I've found a DBMS-agnostic way to do this, which I've got in a commit in my fork of this repo: https://github.com/barendt/actionset/commit/abe9f4203a5195f6e4f32b898f4ad36bfca664ba

Once the dust settles from the changes you're working on now, I'll figure out how to get this change incorporated into that and I'll submit a PR.

emolayi commented 4 years ago

Addressed here: https://github.com/fractaledmind/actionset/pull/66