fractaledmind / solid_errors

database-backed, app-internal exception tracker for Rails applications
MIT License
332 stars 17 forks source link

Resolved errors #56

Closed fractaledmind closed 3 months ago

fractaledmind commented 3 months ago

@acoffman Here is my proposed version of #55.

The index view with the "Unresolved" tab selected looks like this: CleanShot 2024-08-22 at 12 15 40@2x

The show view for an unresolved issue like this: CleanShot 2024-08-22 at 12 15 56@2x

The index view with the "Resolved" tab selected looks like this: CleanShot 2024-08-22 at 12 16 54@2x

and, the show view for a resolved issue like this: CleanShot 2024-08-22 at 12 18 12@2x

WDYT?

acoffman commented 3 months ago

Looks great overall!

If I'm reading the diff correctly, there a couple of dangling Tailwind classes that I introduced for the _nav partial that are no longer being used with your reworked version, they can be removed:

rounded-l-lg rounded-r-lg float-right