Closed Perelandra0x309 closed 3 years ago
To resolve https://github.com/fraction/oasis/issues/543
@Perelandra0x309 the commit log for this is a bit of a mess right now. From what I can see, you created a new commit, then a merge-commit to join the two attempts? I cleaned this up locally by...
master
add-custom-style
branch, and hard-resetting it to the now cherry-picked commitI could force-push this but it is considered (rightfully, IMHO) a bit impolite to force-push into other people's repos, so I'll let you do this. Apart from that, this looks good to me, and I just tried it and love it! Thank you for making this. :)
BTW the failing test is just prettier
complaining about formatting. prettier -w .
will fix that.
@Perelandra0x309 the commit log for this is a bit of a mess right now. From what I can see, you created a new commit, then a merge-commit to join the two attempts?
Yeah I tried to do an amended commit but then git complained that the local branch was behind remote. Does just making a PR modify the remote branch? I tried to correct it and ended up with a mess. Git really irks me sometimes.
OK I made an attempt at a fix, creating a new branch with the final changes, renaming it then doing a force push. It looks like the PR sees just one commit now.
It looks like there still are some formatting issues. I haven't found a set of instructions that get prettier working on my machine yet. By eye the code looks like it conforms to the rest but there are no indications in the build check exactly what it doesn't like.
Oh damn I forgot to include the documentation.
OK I think this PR is ready now if the formatting warnings are not too egregious. Thanks for putting up with a first time node.js hacker (I'm not a true developer).
It looks like npm test
is failing, would you mind running npm run fix
to pass the formatting tests please?
Hooray, this works for me and all the tests/linting/formatting issues are gone, too! Thank you for this @Perelandra0x309!
What's the problem you solved?
Adjusting stylesheet values to change things such as the main content width requires editing the stylesheets included in the oasis source code.
What solution are you recommending?
Allowing the user to modify stylesheet values such as content width using a stylesheet file saved in their oasis configuration folder.