Separate edit and preview view for posts and comments

fraction / oasis

Free, open-source, peer-to-peer social application that helps you follow friends and discover new ones on Secure Scuttlebutt (SSB).

http://oasis-demo.fraction.io

GNU Affero General Public License v3.0

286 stars 42 forks source link

Separate edit and preview view for posts and comments #611

Open lindskog opened 3 years ago

lindskog commented 3 years ago

Fixes https://github.com/fraction/oasis/issues/537

What's the problem you solved?

Message preview seems to submit the contents of the preview, even if additional edits have been made (issue https://github.com/fraction/oasis/issues/537)

What solution are you recommending?

Instead of the recommended solution in the issue I discussed this with some people and suggest that edit and preview of posts and comments are separated into two different views, to create a more natural and less confusing user/data flow.

Powersource commented 3 years ago

Thanks for the PR!

Tried it out and seems to work well.

But the user flow when mentioning someone gets a bit weird since the people you might mention are showed to you on the preview screen and if you want to mention them you have to copy the mention and then click Edit to go back and use the mention. But maybe this is fine for now, overall an improvement and we should merge for now, what do you think @christianbundy ? In another PR we could maybe add another button next to the Preview button, that says "Get mentions" or something, that keeps you on the edit screen but lists the possible mentions for you?

christianbundy commented 3 years ago

Thanks for working on this issue. I agree that this is a step backward for mentions, is it possible to implement this in a way that doesn't break that feature? If you'd like, I'm happy to discuss on GitHub so that we can come up with a solution that'll work. I didn't see any conversation in #537.