search

fraction / oasis

Free, open-source, peer-to-peer social application that helps you follow friends and discover new ones on Secure Scuttlebutt (SSB).
http://oasis-demo.fraction.io
GNU Affero General Public License v3.0
286 stars 42 forks source link

Crashes on loading certain images #614

Open Powersource opened 3 years ago

Powersource commented 3 years ago

What's the problem you want solved?

I'm running latest master and visit my own likes page http://localhost:3000/likes/%40Vz6v3xKpzViiTM%2FGAe%2BhKkACZSqrErQQZgv4iqQxEn8%3D.ed25519

The page loads but oasis crashes and i get this in the terminal. Guessing it's one of the profile pics/attached images that fail to load?

/home/me/prj/ssb/oasis/src/index.js:132
    throw err;
    ^

[Error: VipsJpeg: Corrupt JPEG data: 50 extraneous bytes before marker 0xd4
vips2png: unable to write to target target
]

Is there a solution you'd like to recommend?

Would need to debug more to find the broken image/whatever.

christianbundy commented 3 years ago

Oh, interesting bug. Thanks for reporting this. I'd probably put the offending code in a try...except block to avoid the throw.