fracture91 / ignpp

Firefox and Chrome extension for boards.ign.com
http://vestitools.pbworks.com/
3 stars 2 forks source link

3.0.0a1 version compatibility was not automatically bumped to 17.* #286

Open fracture91 opened 11 years ago

fracture91 commented 11 years ago

2.2.2 was fine

https://addons.mozilla.org/en-US/developers/addon/ign/validation-result/153450

`toString` for function objects has changed.

Error: The `toString` implementation for function objects have changed. If you are using `eval` or `Function` to change the behavior of 'native' functions, it is probably not working correctly in Firefox 17 and above.

Error: See https://bugzilla.mozilla.org/show_bug.cgi?id=761723 for details.

This has to do with the removal of the decompiler - toSource/String now gets its data from the original JS source, so it might break addons that do gross patching of existing code by using those methods. I seriously doubt that this broke anything, but I should make sure and then make the manual compatibility bump if everything's fine.