fradelg / docker-mysql-cron-backup

Docker image to backup all your databases periodically
Apache License 2.0
305 stars 111 forks source link

Add ability to get mysql password from file #67

Closed skimpax closed 2 years ago

skimpax commented 2 years ago

Hello,

To avoid putting cleartext password in docker-compose file, use the facility to put the password in a file, as used by docker secrets. The file path is to be set set in MYSQL_PASS_FILE. In case of use in docker secret, path shall be /run/secrets/my_docker_secret_name

Regards.

fradelg commented 2 years ago

Hi! Thank you for your contribution. If you can address my comment I will be happy to merge your PR with master

skimpax commented 2 years ago

Sorry for the delay. Shall be OK now.

fradelg commented 2 years ago

No worries, thanks for your contribution