check for invalid column and table names

fraenky8 / tables-to-go

convert your database tables to structs easily

MIT License

233 stars 42 forks source link

check for invalid column and table names #21

Closed ronniegane closed 5 years ago

ronniegane commented 5 years ago

resolves #18 This now does the following:

Replaces any whitespace in table or column names with underscores.
Checks for any characters in table or column names that aren't valid Go identifiers (allows Unicode letters, digits and underscores), and throws an error if it finds them. This is built on top of the branch for #19 so that you can ignore these errors if you want to.

ronniegane commented 5 years ago

I pulled the column formatting out into a function that is easy to unit test: 719aecfbdaa7 That seemed simpler than having to set up tables and DBs. The test cases show how the columns will be formatted, @fraenky8 can you check that those have the desired behaviour for original and camelcase?

Do you want me to rename table names that start with numbers as well? At the moment it's only renaming columns.