search

fraenky8 / tables-to-go

convert your database tables to structs easily
MIT License
233 stars 42 forks source link

mysql: support mysql 5.5 #3

Closed suzuken closed 6 years ago

suzuken commented 6 years ago

datetime_precision is only supported MySQL 5.6.4 or later.

fixes #2

fraenky8 commented 6 years ago

Hi!

thanks for investigating this bug, i only tested with MySQL 5.6.+

I think you're right, we can drop the field datetime_precision - i only included it for consistency reasons throughout the various databases.

Can you also delete the field DatetimePrecision of the Column-struct? So we have no dangling unfilled fields. After that i wil merge your PR and close the issue!

Thanks in advance

suzuken commented 6 years ago

Can you also delete the field DatetimePrecision of the Column-struct? So we have no dangling unfilled fields. After that i wil merge your PR and close the issue!

Sure. I'd do it.

suzuken commented 6 years ago

fixup