search

fragaria / angular-daterangepicker

Angular.js wrapper for dangrossman/bootstrap-daterangepicker
MIT License
519 stars 372 forks source link

Move clear label to locale config #126

Closed fracz closed 5 years ago

fracz commented 8 years ago

Before:

options = {
  clearLabel: "Clear"
}

After:

options = {
  locale: {
    clearLabel: "Clear"
  }
}

I have seen you moved all other options to locale, too (i.e. format or separator). clearLabel in locale seems to be more consistent.

krtek commented 8 years ago

This would be a breaking change, right? But you're right...

jasdeepsingh commented 8 years ago

Makes sense to have this under locale 👍