search

fragaria / angular-daterangepicker

Angular.js wrapper for dangrossman/bootstrap-daterangepicker
MIT License
519 stars 372 forks source link

Add back check for undefined model value #136

Closed ostlund closed 5 years ago

ostlund commented 8 years ago

In fragaria/angular-daterangepicker@0a31db8e3953b9666eed839cc2754ce829f46fd3 the refactoring resulted in that a undefined/null check was removed. This pull request adds it back again.

egesu commented 8 years ago

+1

vincez commented 8 years ago

+1. Please pull this - this bug is killing us.

viacoban commented 8 years ago

+1

hernan-almeida commented 8 years ago

+1. Semi related to this issue, when the date is initialized as null, the date picker doesn't allow to select the current date.

JanPalaxo commented 7 years ago

+1

barbossa commented 7 years ago

+1

aevo-tech commented 7 years ago

+1

ghost commented 7 years ago

Why don't you merge this? 👍

greg-mckeon commented 7 years ago

+1

vTodorov commented 7 years ago

+1

enkelmedia commented 7 years ago

@krtek Saw that you needed help with maintaining the repo. I can just say that this PR is say is safe to add and fixes a very annoying issue. Just do it =D

bjarnef commented 6 years ago

Two years after this PR has been submitted it still seems to be an issue with latest version :/

image

b4z81 commented 6 years ago

Please merge this PR in master!