search

fragaria / angular-daterangepicker

Angular.js wrapper for dangrossman/bootstrap-daterangepicker
MIT License
519 stars 372 forks source link

use startDate =, endDate = instead of setStartDate() and setEndDate() #210

Closed jasdeepsingh closed 6 years ago

jasdeepsingh commented 7 years ago

The plugin kept raising errors at various occasions for me when initializing, specifically on these functions:

_picker.setStartDate()
_picker.setEndDate()

The error I had been getting was: 

TypeError: _picker.setStartDate is not a function

I've changed these to directly manipulate the properties startDate & endDate, works fine for me now.

Thought I'd contribute back if others are experiencing similar issues?

jasdeepsingh commented 7 years ago

@krtek Any thoughts on this PR?

jasdeepsingh commented 7 years ago

@fragaria just going through my open PR's (which I do periodically), and wondering if there are any plans on having this merged in?

erperejildo commented 4 years ago

I know this is old but did you fix it @jasdeepsingh ?