search

fragaria / angular-daterangepicker

Angular.js wrapper for dangrossman/bootstrap-daterangepicker
MIT License
519 stars 372 forks source link

Do not use Moment objects, use dates! #318

Open ghost opened 3 years ago

ghost commented 3 years ago

I don't understand why an AngularJS library needs to manage dates as Moment objects. For example, it is wrong for filters. Here is a demo.

ghost commented 3 years ago

Besides, if dates (startDate and/or endDate) are defined with dates, it fails. For avoid this, it is necessary some code like: Date.prototype.isValid = angular.noop;.