search

fraggjkee / sms-confirmation-view

A custom Android's View implementing all the necessary UI for a typical "enter SMS / PIN code" flow.
Apache License 2.0
79 stars 27 forks source link

issue 9 fix del on soft keyboard #10

Closed Lobynya closed 1 year ago

Lobynya commented 1 year ago

Hello, this fix for issue 9 (Keycode del not work on soft keyboard) this problem was described here https://issuetracker.google.com/issues/36964165 and here https://stackoverflow.com/questions/14560344/android-backspace-in-webview-baseinputconnection/14561345#14561345

fraggjkee commented 1 year ago

Hey @Lobynya, thanks for your contribution! I guess you tested the library on both types of the devices (the ones that are affected by the keyboard bug + the ones that are note) with your additions, right? Just wanted to double-check that this edge-case fix does not affect the "happy path" flow when the backspace key action is properly reported by the OS / software keyboard.

AmrAbuelhamd commented 1 year ago

hello, his code does fix the problem, i had to create aar manually to include the library to include this fix, merge his changes please)

https://user-images.githubusercontent.com/37804517/236399479-9acc0da8-1f97-41fb-9c13-47cbfdb0cae7.mp4

https://user-images.githubusercontent.com/37804517/236399515-e9ad8d3a-c8f7-4d07-aabf-ed8db90bc916.mp4