fraggjkee / sms-confirmation-view

A custom Android's View implementing all the necessary UI for a typical "enter SMS / PIN code" flow.
Apache License 2.0
79 stars 28 forks source link

Individual Id's for fields #13

Closed mga47 closed 4 months ago

mga47 commented 4 months ago

Can you please add Id's when creating fields? I get issue from QA team.

In Verification code screen resource-id Attributes are missing. It is blocking me locate OTP fields and automate Verification code screen flow. Please add resource-id's for every OTP fields

fraggjkee commented 4 months ago

What "fields" are we talking about here? Individual cells (with single digits) or the overall "sms confirmation view" component?

mga47 commented 4 months ago

It's about individual cells, not the whole component.

On Thu, Jun 13, 2024, 19:31 Anton Stulnev @.***> wrote:

What "fields" are we talking about here? Individual cells (with single digits) or the overall "sms confirmation view" component?

— Reply to this email directly, view it on GitHub https://github.com/fraggjkee/sms-confirmation-view/issues/13#issuecomment-2166014825, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJRHJBVIFVA2HLOAURYXODZHG3L5AVCNFSM6AAAAABJILSITOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWGAYTIOBSGU . You are receiving this because you authored the thread.Message ID: @.***>

fraggjkee commented 4 months ago

Hm... Maybe I'm missing something here, but why do they need to validate individual symbols? Can't you guys just assign some ID to the SmsConfirmationView itself and then in your automation tests locate that view and check the actual entered code via the enteredCode property?

On Thu, 13 Jun 2024 at 17:38, Gar Mkrtchyan @.***> wrote:

It's about individual cells, not the whole component.

On Thu, Jun 13, 2024, 19:31 Anton Stulnev @.***> wrote:

What "fields" are we talking about here? Individual cells (with single digits) or the overall "sms confirmation view" component?

— Reply to this email directly, view it on GitHub < https://github.com/fraggjkee/sms-confirmation-view/issues/13#issuecomment-2166014825>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/ADJRHJBVIFVA2HLOAURYXODZHG3L5AVCNFSM6AAAAABJILSITOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWGAYTIOBSGU>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/fraggjkee/sms-confirmation-view/issues/13#issuecomment-2166031730, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJKO5OZ7KAWKPEVRM5BNGLZHG4F5AVCNFSM6AAAAABJILSITOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWGAZTCNZTGA . You are receiving this because you commented.Message ID: @.***>

fraggjkee commented 4 months ago

I view this component as a kind of EditText so it just provides the text (code) that is currently entered, individual cells are internal details that can be changed to let's say 1 single drawing phase without actual subviews, in this case it won't technically be possible to assign distinct IDs to each symbol.

On Fri, 14 Jun 2024 at 09:56, Стульнев А.Ю. @.***> wrote:

Hm... Maybe I'm missing something here, but why do they need to validate individual symbols? Can't you guys just assign some ID to the SmsConfirmationView itself and then in your automation tests locate that view and check the actual entered code via the enteredCode property?

On Thu, 13 Jun 2024 at 17:38, Gar Mkrtchyan @.***> wrote:

It's about individual cells, not the whole component.

On Thu, Jun 13, 2024, 19:31 Anton Stulnev @.***> wrote:

What "fields" are we talking about here? Individual cells (with single digits) or the overall "sms confirmation view" component?

— Reply to this email directly, view it on GitHub < https://github.com/fraggjkee/sms-confirmation-view/issues/13#issuecomment-2166014825>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/ADJRHJBVIFVA2HLOAURYXODZHG3L5AVCNFSM6AAAAABJILSITOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWGAYTIOBSGU>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/fraggjkee/sms-confirmation-view/issues/13#issuecomment-2166031730, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJKO5OZ7KAWKPEVRM5BNGLZHG4F5AVCNFSM6AAAAABJILSITOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWGAZTCNZTGA . You are receiving this because you commented.Message ID: @.***>

mga47 commented 4 months ago

Same here, I also see use it as single view component. Okay, I'll try to understand their issue in that case, thanks for reply.

mga47 commented 4 months ago

Closed