search

fragglet / agito

Subversion to Git conversion script
GNU General Public License v2.0
11 stars 6 forks source link

commit/author dates #11

Open glensc opened 8 years ago

glensc commented 8 years ago

https://github.com/fragglet/agito/blob/17603c6f4d3f81f55d5a5fb961a4b8daef8a0dfd/agito.py#L717-L719

why you have decided to use UTC as commit dates? i understand svn does not have timezone info, but most clients (svn cli, trac) show it in local timezone. and if you store date as UTC, it will appear so in git log, git show commands as well:

$ git show
Date:   Tue Feb 16 12:50:29 2016 +0000

i would rather see:

$ git show
Date:   Tue Feb 16 14:50:29 2016 +0200
glensc commented 8 years ago

i was thinking filling GIT_AUTHOR_DATE and GIT_COMMITTER_DATE using Git internal format so it could be altered using FILTER_BRANCH_CALLBACK

i wonder would Dulwich like it...