Stop using predictable paths under /tmp for tests

fragglet / lhasa

Free Software LHA implementation

http://fragglet.github.io/lhasa/

ISC License

80 stars 15 forks source link

Stop using predictable paths under /tmp for tests #15

Closed jmtd closed 10 years ago

jmtd commented 10 years ago

Most of the tests use predicable paths for intermediate files in /tmp. This is a problem on multi-user systems, as it makes the test suite vulnerable to symlink attacks. It may also cause problems with things like buildds.

All tests except 'test-extract' are fixed in this patch (that's a bigger piece of work).

fragglet commented 10 years ago

Thanks, and sorry for being slow in merging.

jmtd commented 10 years ago

No probs! FWIW the one test I haven't fixed yet is the one that (I think) is causing the issues on the Debian auto builders, but it's quite cwd-sensitive so need more careful adjustment.