search

fragglet / sdl-sopwith

Classic bi-plane shoot-'em up
https://fragglet.github.io/sdl-sopwith
GNU General Public License v2.0
71 stars 13 forks source link

Suggestion: Replace macro SOPWITH1_TUNE with a menu option #40

Closed NY00123 closed 7 months ago

NY00123 commented 8 months ago

The idea here is to add a toggle that lets you select between Sopwith 1 and 2's tunes.

Last time I checked it (probably around mid-2023 or a bit later), it was obviously not just a matter of replacing the macro SOPWITH1_TUNE with a variable. I wasn't sure what would be the right approach in case the user changes the tune while it's already playing.

fragglet commented 7 months ago

I've considered it in the past but I don't think it would be worth the additional clutter on the options menu. I'm planning to add the ability to override the tune in custom map files so that would be an option for people who really want to hear it instead of the Sopwith 2 tune.

NY00123 commented 7 months ago

ok, I've actually thought about giving this a try again and implementing it before your comment. Either with the toggle not immediately having an immediate effect while tune is already playing, or the opposite (by stopping tune being played and starting the other one if actual game was not started). I've also thought it should be consistent with the presence of existing menu toggles, like "Solid ground". Given your response, I can leave this by the side.

fragglet commented 7 months ago

So if you've already put some work into it, maybe you could adapt your existing work into adding a new field to the map format? I think it should be relatively straightforward.

On Sat, 10 Feb 2024, 13:15 NY00123, @.***> wrote:

ok, I've actually thought about giving this a try again and implementing it before your comment. Either with the toggle not immediately having an immediate effect while tune is already playing, or the opposite (by stopping tune being played and starting the other one if actual game was not started). I've also thought it should be consistent with the presence of existing menu toggles, like "Solid ground". Given your response, I can leave this by the side.

— Reply to this email directly, view it on GitHub https://github.com/fragglet/sdl-sopwith/issues/40#issuecomment-1937087029, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXUNPOUV7NWMGLJRETIA3YS62LPAVCNFSM6AAAAABCZDR6KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXGA4DOMBSHE . You are receiving this because you modified the open/close state.Message ID: @.***>

NY00123 commented 7 months ago

I haven't done such work so far. What I probably did earlier in 2023 was not much more than undefining SOPWITH1_TUNE and inspecting the code.

If you indeed add the feature for user maps, question is if it'll be specific to the maps themselves or also hold to the menu before starting a proper game, say if you add the option of selecting a user map from the menu. But that's probably a topic for discussion outside of this issue, if at all.